` related: `#5085 `_ * Packages: ``Neos`` ``Media.Browser`` `BUGFIX: Sort roles for users by label instead of internal name in the UI `_ ------------------------------------------------------------------------------------------------------------------------------------------- **Review instructions** Before: !`CleanShot 2024-08-15 at 13 01 03@2x `_ After: !`CleanShot 2024-08-15 at 13 00 37@2x `_ * Packages: ``Neos`` `BUGFIX: Don’t copy removed nodes `_ ----------------------------------------------------------------------------------------------------- With this change, removed nodes are not copied anymore in the recursive copy actions. Also the removed state is now kept when a node is similarisied to prevent unpublished removed nodes from popping up again inadvertendly. * Resolves: `#5185 `_ * Packages: ``Neos`` ``ContentRepository`` `BUGFIX: Don’t include subnodetypes of subnodetypes in node search `_ -------------------------------------------------------------------------------------------------------------------------------------- The subnodetypes of the given filter are collected twice (once in the ``NodesController`` and once in the ``NodeDataRepository``) leading to nodetypes being included which don't inherit from the given list of nodetypes as the second list of nodetypes is not checked against the nodetypefilter but against the subnodetypes of the nodetypefilter. See details in #4502. * Resolves: `#4502 `_ * Packages: ``Neos`` `BUGFIX: Changed from hardcoded date format to user-localized format. `_ --------------------------------------------------------------------------------------------------------------------------------------- Changes the hardcoded Y-m-d date format with an user-localized format. German Interface Language !`image `_ English Interface Language !`image `_ **Upgrade instructions** Tested within neos 8.3.15 **Review instructions** Changed the branch to 8.3, as i've `accidentally `_ choose 8.0 👼 As discussed in `slack `_ we (actually Bastian) changed from a hardcoded date format to an user-localization. * Packages: ``Neos`` `BUGFIX: Forward status codes and headers set in module actions `_ --------------------------------------------------------------------------------------------------------------------------------- Previously the status code set in module actions via ``throwStatus`` or ``response->setStatusCode()`` was ignored. With this change the individual module response is merged into the generic module response which then contains the desired status code, headers and other properties. This is essential if the client (f.e. HTMX) relies on proper headers and status codes to behave properly. **Review instructions** Use f.e. ``$this->throwStatus(404)`` in a Neos module controller action and check the status code of the response when calling the action. The response code should now be 404 instead of 200. * Packages: ``Neos`` `BUGFIX: Case insensitive user search on PostgreSQL `_ --------------------------------------------------------------------------------------------------------------------- PostgreSQL is by default case sensitive and its hard to find users depending on their name in the users module. * Packages: ``Neos`` `BUGFIX: Access isNil function from Helper function to apply selected image to property `_ --------------------------------------------------------------------------------------------------------------------------------------------------------- **Upgrade instructions** _None_ **Review instructions** Follow-up to: `#5117 `_ With the latest Bugfix release of Neos 8.3.14 currently when selecting an image from the media browser it not will be applyied to the image property as the ``IsNil`` function has to be accessed inside of the ``Helper`` function. ```javascript NeosCMS.isNil() ``` In this case, leads to an unresolved function or method. ### Before https://github.com/neos/neos-development-collection/assets/39345336/ed761221-924d-467f-bd9f-6eb6c97dd553 ### After https://github.com/neos/neos-development-collection/assets/39345336/2c78211a-c8a8-4f55-808a-15b495fde586 * Packages: ``Neos`` ``Media.Browser`` `BUGFIX: Prevent multiple imports of the same remote asset in the frontend `_ -------------------------------------------------------------------------------------------------------------------------------------------- This is a frontend fix for `#5116 `_and prevents users from triggering multiple import processes for the same remote asset. It is not a sufficient fix to only prevent this in the frontend though, since it doesn't catch it, if two or more different users trigger the import for the same asset at the same time. Changes: - ``select.js``: add data attribute ``data-import-in-process`` to asset once import process has started and remove it when import is done - ``select.js``: check for new data attribute and only start import process if attribute does not exist - ``select.js``: add notification to inform user that asset is being imported - ``select.js``: add notification as warning for user if import is already in process - ``Main.xlf``: add new notification messages for english - ``Default.html``: add id for notification container to be able to send notifications to it via js - ``Configuration.js``: update ``hasConfiguration`` after configuration object was created, because otherwise it will always be false and the translations don't work ``related:`` https://github.com/neos/neos-development-collection/issues/5116 **Info for testing:** You need to bundle the Neos.Neos assets to get the text for the notification messages. - navigate to the Neos.Neos package - run ``yarn`` - run ``yarn build`` * Packages: ``Media.Browser`` `BUGFIX: Flush cache also for deleted nodes `_ ------------------------------------------------------------------------------------------------------------- Removed nodes can't get found, so they regarding caches don't get flushed. The bug was introduced with `#4291 `_ * Fixes: `#5105 `_ * Packages: ``Neos`` `BUGFIX: Fix title attribute for impersonate button in user management `_ ---------------------------------------------------------------------------------------------------------------------------------------- With this change the localized text is rendered instead of always defaulting to english. Changes: - ImpersonateButton.js change postion of const localizedTooltip inside ImpersonateButton function and change isNil(window.Typo3Neos) to isNil(window.NeosCMS) - RestoreButton.js it was always fallback text used change isNil(window.NeosCMS) to !isNil(window.NeosCMS) * Fixes: `#4511 `_ Checklist - [ ] Code follows the PSR-2 coding style - [ ] Tests have been created, run and adjusted as needed - [x] The PR is created against the `lowest maintained branch `_ - [x] Reviewer - PR Title is brief but complete and starts with ``FEATURE|TASK|BUGFIX`` - [ ] Reviewer - The first section explains the change briefly for change-logs - [ ] Reviewer - Breaking Changes are marked with ``!!!`` and have upgrade-instructions * Packages: ``Neos`` `BUGFIX: Workspace module: Tweak UX for collapsed rows in rewiew `_ ---------------------------------------------------------------------------------------------------------------------------------- This change adds a checkbox to all rows of the workspace review module in order to get a unified look and feel when collapsing those lines. Previously, the checkbox was hidden for documents that only contained a single change: !`image `_ With this change, the list looks cleaner and single changes can be selected more easily even when collapsed: !`image `_ * Packages: ``Neos`` `BUGFIX: Fix handling of unset/nulled DataStructure keys `_ -------------------------------------------------------------------------------------------------------------------------- Re-establishes the Neos < 8.0 behavior of removed/nulled data structure keys ## Background: With `#3645 ``_a lot of Fusion core logic was refactored. As an unwanted side-effect, ``Neos.Fusion:DataStructure`` prototypes (effectively all implementations of the ``AbstractArrayFusionObject`) now behave differently when it comes to removed or nulled keys and ```fusion Neos.Fusion:DataStructure { someProperty > } ``` led to an array with: ```json {"someProperty":[]} ``` in Neos 8.0+. This fix reverts this side-effect, making the above return ```json [] ``` again. * Fixes: `#3859 `_ * Related: `#3577 `_, #3646 * Packages: ``Neos`` ``Fusion`` `BUGFIX: Invalidate caches correctly after node move changes have been discarded `_ -------------------------------------------------------------------------------------------------------------------------------------------------- **NOTE:** This PR needs to be tested in combination with its companion PR over at ``neos-ui``: https://github.com/neos/neos-ui/pull/3503 ## The overall problem This one's a bit complex and it stretches over two repositories. The basic scenario is: 1. You move some (document) node(s) to a position below a different parent node (so, just sorting them within their own hierarchical level doesn't count) 2. You discard those changes 3. Chaos ensues https://github.com/neos/neos-ui/issues/3184 describes the issues that happen only partially. During my investigation I found several problems that I need to disect piece by piece. ## (I) The UI does not (entirely) recognize that nodes have been moved to a position below a different parent node **The problem** https://github.com/neos/neos-ui/assets/2522299/9ce3bdb9-35d7-423d-90af-b2c55a009c9d In the video you can see that after the two document nodes have been moved, the change is not made visible by the usual orange change indicator on the left hand side of the tree nodes. Also, on the attempt to discard the current set of changes, an error occurs that reads: ``` Call to a member function isRemoved() on null - Check logs for details ``` Both phenomena are related, because - as it turns out - the ``UpdateWorkspaceInfo`` feedback object, that is supposed to inform the UI about pending changes, delivers the wrong node context paths for the nodes that have just been moved (the context paths are still the old ones). Because the context paths are now out of sync, the UI is unable to associate the pending change with the respective tree node. It then also uses the stale workspace information as payload to the discard command, which leads to the above error at the following line: https://github.com/neos/neos-ui/blob/`5c52e08b8a1effc985911390a7124579c4018c25 `_/Classes/Controller/BackendServiceController.php#L272 How come the context paths are incorrect after the nodes have been moved? After some investigation I found that the ``Neos\\ContentRepository\\Domain\\Factory\\NodeFactory`` class memoizes stale data - as opposed to e.g. ``ContentContext`` which gets its in-memory cache flushed when nodes were moved: https://github.com/neos/neos-development-collection/blob/`0e28ef208111f5b1576df9078bb9abfedf12500c `_/Neos.ContentRepository/Classes/Domain/Factory/NodeFactory.php#L81 When the ``PublishingService`` is asked for unpublished nodes via ``getUnpublishedNodes``, it receives cache hits within ``NodeFactory->createFromNodeData`` for the nodes that have just been moved - thus the old context paths. **EDIT:** Not at all true :sweat_smile:! I investigated further after the functional tests over here failed (hooray for functional tests!). The actual reason is as follows: The Neos UI API uses a slightly different content context configuration than ``getUnpublishedNodes``. So, ``NodeFactory`` actually keeps track of two variants of the moved nodes. The ones that ``getUnpublishedNodes`` receives are not the ones that the move operation has been performed on. **The solution** The solution for this is implemented over here: https://github.com/neos/neos-ui/pull/3503 ## (II) Discarded move changes are not properly reflected in the document tree **The problem** Problem (I) can be circumvented by hard-reloading the UI (after that, the workspace info will be correct again). But, there's still some strangeness going on... https://github.com/neos/neos-ui/assets/2522299/9f4e6d55-9c92-4590-8b1a-362532f7f799 In the video you can see that the tree actually reflects the discarded changes correctly for a brief moment there. It then quickly jumps to a broken state in which the nodes that should be at their original positions just disappear. This problem persists even if you hard-reload the UI after discarding: https://github.com/neos/neos-ui/assets/2522299/7085ee21-91a3-428a-a5e0-55bc0a7899a6 Now, if you use the reload button of the document tree to manually reload the tree, the nodes reappear: https://github.com/neos/neos-ui/assets/2522299/c7b2dafd-8113-4a28-a3a8-ac3bc56675f8 (But also: If you hard-reload the UI again, the nodes will once again flash briefly and then disappear) How does this happen? In those videos, the parent document that originally contained the moved nodes is focused and open in the guest frame. After discard, it should contain those nodes again. The UI reloads the guest frame, but the document is now rendered with stale node metadata. After the guest frame finished loading, the stale metadata (which still thinks the nodes have been moved elsewhere) overwrites the node data in the UI redux store. This is why the correct state shows up for a brief moment. It gets overwritten after a short delay when the guest frame is loaded. (Also: The nodes do not disappear if you focus a different document and hard-reload the UI). Looking at the cache configuration for the node metadata: https://github.com/neos/neos-ui/blob/`5c52e08b8a1effc985911390a7124579c4018c25 `_/Resources/Private/Fusion/Prototypes/Page.fusion#L26-L46 ... one should actually assume that the data shouldn't be stale (``Neos.Caching.descendantOfTag(documentNode)`` should do the trick). It turns out though, that the ``Neos\\Neos\\Fusion\\Cache\\ContentCacheFlusher`` class - in case of discard - will only flush tags related to a node's current workspace. We actually need to have all tags flushed in the base workspace as well to cover the ``DescendantOf_*``-tag of the original parent node. **The solution** I'm not entirely sure about this. I did two things: 1. I modified the ``nodeDiscarded`` signal so that it carries the base workspace of each discarded node The reason behind this is that the ``ContentCacheFlusher`` listens to both the ``nodeDiscarded`` and the ``nodePublished`` signal with its method ``registerNodeChange``. ``nodePublished`` carries the target workspace of the publishing operation, which is accepted as a second argument by ``registerNodeChange``. ``nodeDiscarded`` used to not carry such "target workspace" information, so that the ``ContentCacheFlusher`` had no chance to actually flush tags for this workspace. It feels to me like a bit of a stretch on semantics to just add the base workspace to the ``nodeDiscarded`` signal in such fashion, but I found it to be the least invasive yet most effective solution. 2. I made sure that the ``registerAllTagsToFlushForNodeInWorkspace`` method of the ``ContentCacheFlusher`` actually deals with the given node in the given workspace. ``registerAllTagsToFlushForNodeInWorkspace`` takes a node and a workspace as arguments. It used to just assume that the given node is actually its variant in the given workspace, which seems to be working in a lot of cases, but in the case of discarded node move changes, the method makes false assumptions. It goes up the parent chain of the given node to find all ``DescendantOf_*``-tags that need to be flushed. The given node however has the wrong parent. I therefore added some code at the start of the method, that replaces the ``$node`` variable with the given node's variant in the given workspace, if the respective workspace names differ. *Related Commit(s):* https://github.com/neos/neos-development-collection/pull/4291/commits/`f97268a7a3b4259285b45a7a0ed7572d0e03d02a ``_, https://github.com/neos/neos-development-collection/pull/4291/commits/``184692dd6398924ff769fc8d452454d3427f92c0 `_ ## (III) Discarding a node move while having a moved document node open in the guest frame results in an error page **The problem** https://github.com/neos/neos-ui/assets/2522299/7ddda073-47b7-4587-bf3f-ad5c50bdf411 The video shows that when you're currently editing a moved document and then discard the move change, the guest frame reloads and shows a misleading fusion error. This is because the guest frame tries to render a document node that doesn't exist anymore. A similar situation would be a document that has just been created. If you stay on that document and then discard it, the UI behaves correctly and redirects you to the next-higher document: https://github.com/neos/neos-ui/assets/2522299/bce265f5-507e-4dd2-bb05-9c72d53564a0 Here, the problem lies within the ``discardAction`` of the ``Neos\\Neos\\Ui\\Controller\\BackendServiceController`` which does not recognize discarded move changes and thus misses to inform the UI that it needs to remove the nodes at their former positions and re-insert them at their original positions. **The solution** The solution for this is implemented over here: https://github.com/neos/neos-ui/pull/3503 ## All solutions combined Here's what it looks like when the PRs in ``neos-ui`` and ``neos-development-collection`` are combined: https://github.com/neos/neos-ui/assets/2522299/2904f731-e101-4033-b617-5c196a44bdec `BUGFIX: Add missing type converts for asset subtypes `_ ----------------------------------------------------------------------------------------------------------------------- This prevents the raw data from being base64 encoded into the rendered output of the Neos backend and included in xhr requests from the Neos UI. Additionally the default settings for editor and constraints makes the usage of those affected types easier in nodetype properties. * Resolves: `#5006 `_ **Review instructions** Example nodetype to use in the Neos backend with the raw content mode: ``` 'Neos.Demo:Content.Test': superTypes: 'Neos.Neos:Content': true 'Neos.Demo:Constraint.Content.Column': true 'Neos.Demo:Constraint.Content.Main': true ui: label: Test icon: picture position: start inspector: groups: settings: label: Test Settings properties: video: type: Neos\\Media\\Domain\\Model\\Video ui: label: 'Video' reloadIfChanged: true showInCreationDialog: true inspector: group: 'settings' editor: Neos.Neos/Inspector/Editors/AssetEditor document: type: Neos\\Media\\Domain\\Model\\Document ui: label: Document inspector: group: 'settings' editor: Neos.Neos/Inspector/Editors/AssetEditor audio: type: Neos\\Media\\Domain\\Model\\Audio ui: label: Audio inspector: group: 'settings' editor: Neos.Neos/Inspector/Editors/AssetEditor ``` Without the change in this PR, setting the 3 properties will each increase the size of the ``preview`` html and node change requests. Also errors are thrown if the editor for each property is not defined. With this change, the size of the output does not increase and the editor does not need to be defined anymore. * Packages: ``Neos`` `BUGFIX: Fix the check for RedirectStorageInterface `_ --------------------------------------------------------------------------------------------------------------------- Existance of interfaces needs to be checked with interface_exists * Fixes: `#5000 `_ * Packages: ``Media`` `BUGFIX: Remove br from role tooltip and improve readability `_ ------------------------------------------------------------------------------------------------------------------------------ A ``
`` was displayed as text in the title of roles in the user management module. With this change it is replaced by a proper line break and the parent roles are now displayed as list with their name and identifier. Before: !`CleanShot 2024-04-11 at 13 37 07@2x `_ After: !`CleanShot 2024-04-11 at 13 40 50@2x `_ * Packages: ``Neos`` `BUGFIX: Sort properties in raw content mode `_ -------------------------------------------------------------------------------------------------------------- Previously there was no obvious sorting for properties in the ``Raw content`` mode and the resulting order of properties appeared "random", which is an issue if the properties don't appear in the order the editor should edit them. With this change the sorting option which is also used for the inspector is used to sort the items and therefore giving an option to the integrator on their arrangement. That the inspector order is used for the raw content is not the cleanest solution, but introducing another sorting option also doesn't seem the right choice at this point. * Packages: ``Neos`` `BUGFIX: Make text formatting visible in raw content mode `_ --------------------------------------------------------------------------------------------------------------------------- This change removes the css reset which made it impossible to see any text formatting in raw content mode. Also the font is now set to use the Neos font instead of just arial which matches the backend default font. Before: !`CleanShot 2024-04-11 at 09 26 51@2x `_ After: !`CleanShot 2024-04-11 at 09 23 08@2x `_ * Packages: ``Neos`` `BUGFIX: Strip image to prevent wrong orientation information in exif data `_ -------------------------------------------------------------------------------------------------------------------------------------------- After autorotating the thumbnail image we need to remove the according exif data for the thumbnail, to prevent the thumbnail is shown rotated again. See also: https://github.com/php-imagine/Imagine/issues/467 * Fixes: `#3148 `_ !`image `_ * Packages: ``Neos`` ``Media`` `BUGFIX: Fix argument order of implode() `_ ---------------------------------------------------------------------------------------------------------- Passing the separator after the array is not supported since PHP 8.0 anymore **Upgrade instructions** * Packages: ``Neos`` ``ContentRepository`` `BUGFIX: 4915 fusion `ParsePartials` cache not flushed for symlinked packages `_ ----------------------------------------------------------------------------------------------------------------------------------------------- * Resolves: `#4915 `_ By reverting fix https://github.com/neos/neos-development-collection/pull/4838 Which will lead to the original problem to resurface https://github.com/neos/neos-development-collection/issues/4415 (but silently this time, no one will notice the cache flodding :D) **Upgrade instructions** * Packages: ``Neos`` ``Fusion`` `BUGFIX: Fix disablingSetNoOpenerWorks test for convertUri `_ ---------------------------------------------------------------------------------------------------------------------------- Fixes the disablingSetNoOpenerWorks test for the convertUri. Now, the test respects the value of setNoOpener. fixes: `#3605 `_ * Packages: ``Media`` ``Neos`` `BUGFIX: Search assets in a case-insensitive way `_ ------------------------------------------------------------------------------------------------------------------ This solves the problem that with Postgres the search was case-sensitive. Other database platforms didn’t have this issue as they ran case-insensitive comparisons by default. * Resolves: `#3432 `_ * Packages: ``Media`` `BUGFIX: Allow dimension preset keys to be different from values for DimensionsMenu `_ ----------------------------------------------------------------------------------------------------------------------------------------------------- This removes the implicit convention that dimensionPresetKey must be the same as the dimensionValue. **Review instructions** - Follow the manual to set up a bilingual site: https://docs.neos.io/guide/manual/content-repository/content-dimensions/multiple-languages#configuring-a-bilingual-site - Open frontend with rendering of ``Neos.Neos:DimensionsMenu`` Fixes https://github.com/neos/neos-development-collection/issues/4857 * Packages: ``Neos`` `BUGFIX: Allow non-entity asset variants `_ ---------------------------------------------------------------------------------------------------------- Allow implementations of the ``AssetVariantInterface`` to not be doctrine entities. Without this fix, all ``AssetRepository::find*()`` calls lead to an exception when a class implements the interface but is not an entity (for example because it is just used to generate dummy images for Monocle). ## Steps to reproduce 1. Implement the interface with a new custom class like ```php final class DummyImageVariant implements AssetVariantInterface { // ... } ``` 2. Trigger ``AssetRepository::find*()`` method, eg. by invoking ``./ flow media:removeunused`` ### Expected result No error, the custom implementation should be ignored ### Actual result Exception: ``` Failure while fetching class schema class "Some\\Package\\DummyImageVariant": No class schema found for "Some\\Package\\DummyImageVariant". Type: Doctrine\\ORM\\Mapping\\MappingException Code: 1542792708 File: Data/Temporary/Development/Cache/Code/Flow_Object_Classes/Neos_Flow_Persist ence_Doctrine_Mapping_Driver_FlowAnnotationDriver.php Line: 187 ``` * Packages: ``Media`` `BUGFIX: Neos Ui JSON serializable property values `_ -------------------------------------------------------------------------------------------------------------------- This bugfix will make use of the ``\\JsonSerializable`` interface instead directly when serializing properties for the neos ui. With https://github.com/neos/flow-development-collection/pull/2762 native support for vo's in ``flow_json_array`` was introduced. That also allows value object support for node properties, as they can be stored directly the node properties flow_json_array. Unfortunately the property serialisation for the NeosUi does NOT use the expected ``\\JsonSerializable::jsonSerialize`` but the property mapper and the ``ArrayFromObjectConverter`` for object types to get an array that will be json encoded. This works mostly fine but in some cases it fails: - when your ``fromArray`` fields and property names values dont match - when a "object" subtypes the object mapper is no convertable like the ``GuzzleHttp\\Psr7\\Uri``: ``` Too few arguments to function GuzzleHttp\\Psr7\\Uri::isAbsolute(), 0 passed in /core/neos-manufacture-highest/Packages/Framework/Neos.Utility.ObjectHandling/Classes/ObjectAccess.php on line 151 and exactly 1 expected 72 GuzzleHttp\\Psr7\\Uri::isAbsolute() 71 Neos\\Utility\\ObjectAccess::getPropertyInternal(GuzzleHttp\\Psr7\\Uri, "absolute", false, true) 70 Neos\\Utility\\ObjectAccess::getGettableProperties(GuzzleHttp\\Psr7\\Uri) 69 Neos\\Flow\\Property\\TypeConverter\\ArrayFromObjectConverter_Original::getSourceChildPropertiesToBeConverted(GuzzleHttp\\Psr7\\Uri) ``` Current workarounds are aop: https://github.com/sitegeist/Sitegeist.InspectorGadget/blob/`78f5f4a206287b1c4bedf5cb88582ed51cb4a311 `_/Classes/Infrastructure/NodeInfo/NodeInfoPostProcessingAspect.php#L17 Or to use a dumb property mapper: https://github.com/sitegeist/Sitegeist.Archaeopteryx/blob/`9322b9cb8e4824bcaf7aaa247c23b1244a2f1167 `_/Classes/LinkToArrayForNeosUiConverter.php#L12C16-L12C78 **Upgrade instructions** * Packages: ``Neos`` ``ContentRepository`` `BUGFIX: Private props obscure error `_ ------------------------------------------------------------------------------------------------------ …uated instead of the original error that something went wrong > Circular reference detected while evaluating prop: "private.thepath" is shown. That happens because the locking didnt anticipate this case. **Upgrade instructions** **Review instructions** this code reproduces the problem ... yes i know :D ``` prototype(YourVendor:FusionPrototype) < prototype(Neos.Fusion:Component) { @private { lol = ${true} throwingPath = ${private.lol && NonExistingFunctionError()} } renderer = YourVendor:FusionPrototypeWithPrivate { content = ${private.throwingPath} } } prototype(YourVendor:FusionPrototypeWithPrivate) < prototype(Neos.Fusion:Component) { renderer = ${props.content} } ``` * Packages: ``Neos`` ``Fusion`` `BUGFIX: Fusion parser fix multi line comment `_ --------------------------------------------------------------------------------------------------------------- This fixes a bug where the Fusion parser would not parse following c-style comments correctly: ``` /** comment with multiple stars even **/ ``` This happed when the ending count of ``*`` was even. So ending a comment with ``***/`` worked previously. Now we use the "correct" regex from Jeffrey E.F. Friedl's book "Mastering Regular Expressions" Page 272 "Unrolling C Comments" We already use his regex for string matching and it is really fast due to the unrolled loop. Faster than using the lazy quantifier ``~^/\\*.*?\\*/~s``. I did a performance test with 1 million iteration on three different comment samples (with each sample having a dynamic part to clear possible caches): | Unrolled (this pr) | Simple Lazy Quantifier | |--------|--------| | 0.143725s | 0.160235s | | 0.181047s | 0.203759s | | 0.156254s | 0.170144s | Additionally the error message for comments starting with ``/**`` was improved. Previously $nextLine->char(1) would return ``**`` instead of just one ``*`` because wrongly implemented. **Upgrade instructions** * Packages: ``Fusion`` `BUGFIX: Use a dynamic URL for user impersonation `_ ------------------------------------------------------------------------------------------------------------------- As described in the issue, the impersonation does not work when Neos is running in a subfolder. This change adds a data attribute with a dynamic URL to the DOM, and the user impersonation is using this module URL as base. * Fixes: `#4797 `_ **Review instructions** Use the user impersonation in the Backend modules (User Management and other) when Neos is running in a subfolder. e.g. BASEURL.com/cms/neos * Packages: ``Neos`` `BUGFIX: Add assetcollection privilege condition to asset edit view in Media.Browser `_ ------------------------------------------------------------------------------------------------------------------------------------------------------ In the Media.Browser you can change the AssetCollections via checkboxes even when you don't have the privilege (Neos.Media.Browser:ManageAssetCollections) to do so. With this PR the checkboxes are only rendered with the right privilege. * Packages: ``Neos`` ``Media.Browser`` `BUGFIX: MenuHelper uses content dimensions to get node for privilege check `_ --------------------------------------------------------------------------------------------------------------------------------------------- * Resolves: `#4625 `_ The Neos backend MenuHelper received a bugfix to filter sites listed by the menu using NodePrivileges. In case of sites with multiple dimensions the dimensionCombinations are considered too. **Upgrade instructions** **Review instructions** This bugfix tries to fix #4025. If 7.3 and upwards is used on a multi site project with multiple dimensions, it might be that ``` $node = $context->getNode(\\Neos\\ContentRepository\\Domain\\Utility\\NodePaths::addNodePathSegment(SiteService::SITES_ROOT_PATH, $site->getNodeName())); ``` returns ``null``, causing the next line ``` if ($this->privilegeManager->isGranted(NodeTreePrivilege::class, new NodePrivilegeSubject($node))) { ``` to throw an exception. Thus the backend is not accessible anymore. The reason is, that for multisite projects with multiple dimensions it might be that ``$node`` cannot be retrieved by the default context created. The fix is to use ``contentDimensionCombinator`` and also to explicitly check if ``$node`` could be retrieved. I'm also using the property ``invisibleContentShown`` and ``inaccessibleContentShown`` because it might be that an editor set the Home of a site to ``hidden`` by mistake. Thus the site might not accessible via the menu anymore to possibly fix an editor mistake. * Packages: ``Neos`` `BUGFIX: Prevent cache overflow when querying nodes by related entities `_ ----------------------------------------------------------------------------------------------------------------------------------------- Without this change new cache entries in Flow_Persistence_Doctrine are generated for each entry in the relationMap causing massive slowdowns in Neos f.e. when many assets are deleted as the file system cache cannot handle large numbers of entries well. With this change only one entry per number of relations is generated which is usually only a few and the entries can be reused. * Resolves: `#4876 `_ * Packages: ``Neos`` ``ContentRepository`` `BUGFIX: Followup `nodeTypes:show` with `--path` to primitive value `_ ------------------------------------------------------------------------------------------------------------------------------------- * Related: `#4619 `_ Primitive values cannot be shown currently: ``` flow nodetypes:show Neos.Neos:Document --path properties.title.ui.label Neos\\ContentRepository\\Command\\NodeTypesCommandController_Original::truncateArrayAtLevel(): Argument `#1 `_($array) must be of type array, string given ``` **Upgrade instructions** * Packages: ``Neos`` ``ContentRepository`` `BUGFIX: Fusion avoid error parser cache to crash if cache is broken `_ -------------------------------------------------------------------------------------------------------------------------------------- * Resolves: `#4595 `_ It seems a cache's ``has`` operation doesnt work that reliable thats why we will be using ``get`` instead and check against false. **Upgrade instructions** * Packages: ``Neos`` ``Fusion`` `BUGFIX: #3624 Node::getProperty does not always return list for references `_ --------------------------------------------------------------------------------------------------------------------------------------------- EEL can only operate on an array of nodes if the ``[0]`` item is a node (simple duck typing) Instead of fixing eel like proposed here https://github.com/neos/neos-development-collection/pull/3946 with this fix we avoid returning non 0 indexed arrays here: ``` ${q(node).property("someReference")} ``` Currently, this might indeed return an array with holes like ``[1 => NODE, 2 => NODE, 5 => NODE]`` if the identifiers in fields 0, 3 and 4 are not resolvable. Thats because of the "unsafe" ``array_filter`` method in ``resolvePropertyReferences`` https://github.com/neos/neos-development-collection/blob/`378a029d0cc7ea6acb853751e7592873584a4aac `_/Neos.ContentRepository/Classes/Domain/Model/Node.php#L961 which will leave holes in the array. Using ``array_filter`` was introduced with Neos 2.2 so this is technically a regression of https://github.com/neos/neos-development-collection/commit/`87804e12082e7d6d06bd22f50739e20eeaa45539 `_ ^^ * Fixes: `#3624 `_ * Packages: ``Neos`` ``ContentRepository`` `BUGFIX: Add dimensions to Workspace module `_ ------------------------------------------------------------------------------------------------------------- resolves: `#3470 `_ This adds Dimension handling to the current workspaces module. Currently the Module only displays changes in different languages as one change. This is because the node path is the same in different languages after they are copied. * Packages: ``Neos`` `BUGFIX: Fusion avoid error on cache invalidation while developing `_ ------------------------------------------------------------------------------------------------------------------------------------ Replaces `#4509 `_ * Resolves: `#4415 `_ After deleting a fusion file like ``BrandLogo.fusion`` one will face the error after booting flow and thus triggering the file monitor and its listeners: (even like a simple ``flow help``) ``` Couldn't resolve realpath for: '/absolutePath/Code/core/Neos.NeosIo/Packages/Sites/Neos.NeosIo/Resources/Private/Fusion/Content/BrandLogo/BrandLogo.fusion' ``` This is caused as ``realpath`` returns false if the file was deleted, and we were to eager validating this. But as flows file monitor already returns absolute paths we can skip the realpath calculation here and move it to the ``ParserCache::cacheForFusionFile``. Initially the call to ``realpath`` was made in a single place to avoid making to many assumptions about the form flow returned file paths. **Upgrade instructions** * Packages: ``Neos`` ``Fusion`` `BUGFIX: More precise selection of the DomNode with CSFR token `_ -------------------------------------------------------------------------------------------------------------------------------- To prevent issues with selecting the wrong CSFR Token in the DOM, we now have a more precise selection of the DomNode with the CSFR token. fixes: `#4822 `_ **Review instructions** Install a version before 1.0.1 of the `Shel.Neos.WorkspaceModule `_ and go to the user management module to impersonate a user. Then switch to the Workspace module and try to restore the original user. Without this patch, it should fail. With version 1.0.1 it will not fail btw. * Packages: ``Media.Browser`` ``Neos`` `BUGFIX: Check SVG files for malicious code before providing original asset url links `_ ------------------------------------------------------------------------------------------------------------------------------------------------------- This adds a check in the preview of assets in the media module and checks for malicous content in svgs. If detected, the direct links to the original url get removed from the preview pages and a warning is shown. !`image `_ Fixes: - https://github.com/neos/neos-development-collection/issues/4833 - https://github.com/neos/flow-development-collection/issues/3248 * Packages: ``Neos`` ``Media.Browser`` `BUGFIX: Resolve StyleCI issues `_ ------------------------------------------------------------------------------------------------- * Packages: ``Neos`` ``Fusion`` `BUGFIX: Fix StyleCI issues `_ --------------------------------------------------------------------------------------------- * Packages: ``Neos`` `BUGFIX: add dimensionshash migration to postgres `_ ------------------------------------------------------------------------------------------------------------------- Regression https://github.com/neos/neos-development-collection/pull/3279 We need to generate add dimensions hash to node event model in order to be able to save new nodes as we do in MySQL: Neos.Neos/Migrations/Mysql/Version20210125134503.php **Upgrade instructions** Run ./flow doctrine:migrate **Review instructions** You want to make sure that the dimensions table has valid values. If not you might want to add a custom migration like this one: ```php abortIf($this->connection->getDatabasePlatform()->getName() !== 'postgresql', 'Migration can only be executed safely on \\'postgresql\\'.'); $this->addSql('UPDATE neos_neos_eventlog_domain_model_event SET dimension = NULL WHERE dimension = :dimension AND dtype = :dtype;', ['dimension' => 'N;', 'dtype' => 'ttree_contentrepositoryimporter_event']); } public function down(Schema $schema): void { $this->abortIf($this->connection->getDatabasePlatform()->getName() !== 'postgresql', 'Migration can only be executed safely on \\'postgresql\\'.'); $this->addSql('UPDATE neos_neos_eventlog_domain_model_event SET dimension = :dimension WHERE dimension IS NULL AND dtype = :dtype;', ['dimension' => 'N;', 'dtype' => 'ttree_contentrepositoryimporter_event']); } } ``` * Packages: ``Neos`` `BUGFIX: node:repair fails with could not be converted to string `_ ---------------------------------------------------------------------------------------------------------------------------------- Fixes the following crash during node:repair ```shell ./flow node:repair --dry-run --only removeBrokenEntityReferences Dry run, not committing any changes. Checking for broken entity references ... Object of class Neos\\Flow\\Persistence\\Doctrine\\Proxies\\__CG__\\Neos\\Media\\Domain\\Model\\ImageVariant could not be converted to string Type: Error File: Data/Temporary/Development/SubContextWbWeb/Cache/Code/Flow_Object_Classes/Neos_ContentRepository_Command_NodeCommandControllerPlugin.php Line: 836 ``` resolved `#4794 `_ **Upgrade instructions** - [x] Code follows the PSR-2 coding style - ~~Tests have been created, run and adjusted as needed~~ - There are not tests in place and I added none. - [x] The PR is created against the `lowest maintained branch `_ -> 7.3 - [ ] Reviewer - PR Title is brief but complete and starts with ``FEATURE|TASK|BUGFIX`` - [ ] Reviewer - The first section explains the change briefly for change-logs - [ ] Reviewer - Breaking Changes are marked with ``!!!`` and have upgrade-instructions * Packages: ``Neos`` ``ContentRepository`` `BUGFIX: Filter for assets by asset collection by using constraints `_ ------------------------------------------------------------------------------------------------------------------------------------- Fixes a bug, that was introduced with: https://github.com/neos/neos-development-collection/pull/4724 Because of using the QueryBuilder twice, the count of the paramter and for the query is not correct anymore. * Fixes: `#4801 `_ * Packages: ``Neos`` ``Media`` `BUGFIX: Remove unnecessary basemixins dependency for ContentReferences `_ ----------------------------------------------------------------------------------------------------------------------------------------- The package has no direct dependency to the basemixins and should be usable without the other basemixins. * Packages: ``NodeTypes.ContentReferences`` `BUGFIX: Replace incorrect mention of itemRenderer to itemReducer `_ ----------------------------------------------------------------------------------------------------------------------------------- I'm not sure if we should target the 7.0 branch and then apply this to all following versions? Was introduced here: https://github.com/neos/neos-development-collection/commit/`a7bc229541baa91dde6a85fbe4853b88db511af5 ``_#diff-``3ed794da2fb825c61dd55eee6535b77958799b33 `_384df7c47ac2a22242608969R207-R210 * Packages: ``Neos`` `BUGFIX: Add workspace hash to NodeDynamicTag_ and AssetDynamicTag_ cache tags `_ ------------------------------------------------------------------------------------------------------------------------------------------------ * Fixes: `#4781 `_ * Packages: ``Neos`` `BUGFIX: Filter for assets by asset collection without overriding existing WHERE conditions `_ ------------------------------------------------------------------------------------------------------------------------------------------------------------- The query to fetch assets gets build in multiple steps. E.g in ``findAll`` it creates the query, adds the "variant filter clause" and afterwards the "asset collection filter clause". ``` public function findAll(AssetCollection $assetCollection = null): QueryResultInterface { $query = $this->createQuery(); $this->addAssetVariantFilterClause($query); $this->addAssetCollectionToQueryConstraints($query, $assetCollection); return $query->execute(); } ``` But adding the "asset collection filter clause" removes/overrides the existing "variant filter clause" This fix replaces the way of setting "asset collection filter clause", so the existing where clauses are retained. * Fixes: `#4723 `_ * Packages: ``Media`` `BUGFIX: flashmessages in legacy modules work as expected `_ --------------------------------------------------------------------------------------------------------------------------- This applies the, since a while unused, presets for message severity types to notifications in classic Neos backend modules again so that eg. warnings and errors stay on display and can be copied / screenshotted. Also regenerates js maps that seem to have compiled wrongly before. * Fixes: `#4672 `_ * Packages: ``Neos`` `BUGFIX: Check if image is possible to refit on replacement `_ ----------------------------------------------------------------------------------------------------------------------------- * Fixes: `#4752 `_ Checks if the replacement is an image and has a size. * Packages: ``Neos`` ``NodeTypes.BaseMixins`` ``Media`` `BUGFIX: Fix and make `nodeTypes:show` command usable `_ ----------------------------------------------------------------------------------------------------------------------- Fixes handling of invalid nodetype or invalid path. And introduces new option ``level`` to clamp the input (previously this command was useless for bigger nodetypes): ``` flow nodeTypes:show Neos.Demo:Document.Homepage --path properties --level 1 NodeType configuration "Neos.Demo:Document.Homepage.properties": _removed: ... _creationDateTime: ... _lastModificationDateTime: ... _lastPublicationDateTime: ... _path: ... _name: ... _nodeType: ... _hidden: ... _hiddenBeforeDateTime: ... _hiddenAfterDateTime: ... titleOverride: ... metaDescription: ... ... ``` * Packages: ``Neos`` ``ContentRepository`` `BUGFIX: Allow disabling of auto-created Image Variants `_ ------------------------------------------------------------------------------------------------------------------------- Fixes support for the setting ``autoCreateImageVariantPresets`` that was documented for a long time but never actually evaluated. This change set: * Adjusts ``AssetService::assetCreated()`` signal to only trigger ``AssetVariantGenerator::createVariants()`` if the ``autoCreateImageVariantPresets`` flag is set * Sets the default value of the flag to ``true`` for greater backwards compatibility * Adjusts ``AssetVariantGenerator::createVariant()`` to only create a variant if it does not exist already – previously multiple variants with the same identifiers could be created for a single asset leading to undeterministic behavior * Adds a button "Create missing Variants" to the ``Variants`` tab of the Media Module allowing editors to manually trigger creation of (missing) variants. * Fixes: `#4300 `_ * Packages: ``Neos`` ``Media`` `BUGFIX: `props` will be unset after an exception `_ ------------------------------------------------------------------------------------------------------------------- * Resolves: `#4525 `_ The rendering in a Neos.Fusion Component had a bug where the ``props`` might be undefined if an exception happened earlier in an eel expression. This was caused by not correctly poping the runtimes context and thus causing a unexpected shift in the context stack. **Upgrade instructions** * Packages: ``Neos`` ``Fusion`` `BUGFIX: Reduce nodetype schema size `_ ------------------------------------------------------------------------------------------------------ With this change the following optimisations are done to improve speed and reduce size of the schema generation: * Abstract nodetypes are not queried anymore for constraints as they are already resolved by the nodetype manager. * Entries in the inheritance map and constraints will be skipped if they don’t contain any data. These optimisations reduce the size of the schema in the Neos.Demo from ~357KB to ~300KB and improve the response time by ~20% in my tests. The more nodetypes a project has, the bigger the benefit is. **Review instructions** Everything should work the same, adding nodes, constraints, etc. * Packages: ``Neos`` `BUGFIX: Only discard nodes in same workspace `_ --------------------------------------------------------------------------------------------------------------- * Resolves: `#4577 `_ * Packages: ``ContentRepository`` `BUGFIX: Load all thumbnails for an asset to skip further requests `_ ------------------------------------------------------------------------------------------------------------------------------------ For the usecase of images with responsive variants this change prevents additional database requests for each additional variant of an image. This can greatly reduce the number of queries on pages with many source tags or sources attributes for pictures and images. **Review instructions** As soon as an image is rendered in several sizes on a page the patch should skip additional db requests in the thumbnails repository. Persistent resources and image entities are still queried as via the node property getter and to resolve the thumbnail. * Packages: ``Neos`` ``Media`` `BUGFIX: Allow unsetting thumbnail presets `_ ------------------------------------------------------------------------------------------------------------ * Resolves: `#3544 `_ * Packages: ``Neos`` ``Media`` `BUGFIX: Don’t query for abstract nodetypes in nodedata repository `_ -------------------------------------------------------------------------------------------------------------------------------------- As abstract nodetypes don't (shouldn't) appear in the database it makes no sense to query them. This is a regression that was introduced a long time ago, when the default parameter to include abstract nodetypes was added to the ``getSubNodeTypes`` method in the ``NodeTypeManager`` without adjusting the call in the ``NodeDataRepository->getNodeTypeFilterConstraintsForDql`` which relied on the previous behaviour. The call in the method ``getNodeTypeFilterConstraints`` was fixed some years ago, but that method seems unused. * Packages: ``ContentRepository`` `BUGFIX: Consistently initialize asset sources via `createFromConfiguration` `_ ---------------------------------------------------------------------------------------------------------------------------------------------- fixes: `#3965 `_ **The Problem** The case at hand was an asset source that uses a value object to validate the incoming asset source options. I expected to be able to define a promoted constructor property with said value object as its declared type: ```php final class MyAssetSource implements AssetSourceInterface { public function __construct( private readonly string $assetSourceIdentifier, private readonly Options $options ) { } /* ... */ } ``` ...and initialize the value object in the ``createFromConfiguration`` static factory method defined by the ``AssetSourceInterface``: ```php final class MyAssetSource implements AssetSourceInterface { /* ... */ public static function createFromConfiguration(string $assetSourceIdentifier, array $assetSourceOptions): AssetSourceInterface { return new static( $assetSourceIdentifier, Options::fromArray($assetSourceOptions) ); } } ``` This failed with a Type Error, because the ``AssetSourceService``, which is responsible for initializing asset sources, at one point does not utilize ``createFromConfiguration`` to perform initialization, but calls the asset source constructor directly: https://github.com/neos/neos-development-collection/blob/`a4791b623161259b31d2d11b343310bd7ef76507 `_/Neos.Media/Classes/Domain/Service/AssetSourceService.php#L178 **The Solution** I adjusted the aforementioned routine of the ``AssetSourceService`` to use the ``AssetSourceInterface``-defined ``createFromConfiguration`` static factory method instead of the asset source's constructor. Even though the pattern I described above only makes sense in a PHP >8.0 environment, I decided to target Neos 7.3 with this PR, because it should constitute a non-breaking bugfix. * Packages: ``Neos`` ``Media`` `BUGFIX: Guard that Fusion path cannot be empty `_ ----------------------------------------------------------------------------------------------------------------- Previously in php 7.4 this ``Neos\\Fusion\\Exception\\MissingFusionObjectException`` was thrown > No Fusion object found in path "" but with php 8 this ``ValueError`` is thrown which is unexpected > strrpos(): Argument `#3 ``_($offset) must be contained in argument ``#1 `_($haystack) This change takes care of throwing an explicit ``Neos\\Fusion\\Exception`` instead: > Fusion path cannot be empty. -------- This error was noticed in the out of band rendering, when there is no content element wrapping: https://discuss.neos.io/t/argument-3-offset-must-be-contained-in-argument-1-haystack/6416/4

**Upgrade instructions** * Packages: ``Neos`` ``Fusion`` `BUGFIX: Fix `NodeType` `getTypeOfAutoCreatedChildNode` and `getPropertyType` `_ ----------------------------------------------------------------------------------------------------------------------------------------------- resolves partially `#4333 `_ resolves partially `#4344 `_ **Upgrade instructions** * Packages: ``Neos`` ``ContentRepository`` `BUGFIX: show title on hover in ImpersonateButton `_ ------------------------------------------------------------------------------------------------------------------- **Review instructions** Currently if you hovered over the button, the title was not showing up. Since the Feature `#3648 `_was introduced in Neos 8.0 I'm open this against the 8.0 Branch. ### Demo !`SCR-20230803-nhty `_ * Packages: ``Neos`` `BUGFIX: Make getParent work in NodeData `_ ---------------------------------------------------------------------------------------------------------- resolved: `#4283 `_ **Review instructions** I am unsure why the dimensions were not passed to findOneByPath, but without it it does not really work. Also, it is kind of strange that the dimensions in findOneByPath is optional but returns nothing if it is not set. This fixes it for now. * Packages: ``Neos`` ``ContentRepository`` `BUGFIX: Use correct URL to FontAwesome icons `_ --------------------------------------------------------------------------------------------------------------- **Upgrade instructions** * Packages: ``Neos`` `BUGFIX: Assign original asset collections to variant `_ ----------------------------------------------------------------------------------------------------------------------- * Fixes: `#3560 `_ * Packages: ``Neos`` `BUGFIX: Fix editing of Electronic Address type in Backend module `_ ----------------------------------------------------------------------------------------------------------------------------------- * Fixes: `#4418 `_ * Packages: ``Neos`` `BUGFIX: Disable content element wrapping and inline editable for references in content reference list `_ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ The NeosUI tries to initialize the inline editor for rendered references in content reference list. But they are not accessable at this moment. As references shouldn't get edited anyways, we can simple disable the content element wrapping for these references. Fixes https://github.com/neos/neos-ui/issues/3574 * Packages: ``Neos`` ``NodeTypes.ContentReferences`` `BUGFIX: Disable publish checkmark for new pages in workspace `_ ------------------------------------------------------------------------------------------------------------------------------- closes `#3991 `_ **Review instructions** If the document is new, I show a small disabled checkmark instead of the functioning checkmark. This will force the user to use the checkboxes on the left side to publish changes. This does not solve the underlying problem but it will at least disable the function for Editors. Bildschirmfoto 2023-05-12 um 11 12 21

* Packages: ``Neos`` `BUGFIX: Fusion's FilePatternResolver windows compatible `_ -------------------------------------------------------------------------------------------------------------------------- resolves `#4358 ``_in combination with ``#4374 `_ The FilePatternResolver is responsible to handle glob patterns in includes in fusion. For more in depth information see the test: https://github.com/neos/neos-development-collection/blob/`a461dbc8f976588b30f34a5ed34f1eeebf5a0cd2 `_/Neos.Fusion/Tests/Unit/Core/Parser/ParserIncludeTest.php#L156-L167 **Upgrade instructions** * Packages: ``Neos`` ``Fusion`` `BUGFIX: Allow string position values in NodeType schema `_ -------------------------------------------------------------------------------------------------------------------------- The PositionalArraySorter implementation allows string values for the position of nodetypes, tabs, groups and views since a long time but the schema validation showed warnings. **Review instructions** Open the ``NodeTypes`` tab in the ``Configuration`` module with the Neos.Demo and the previous validation warnings shouldn't show up anymore. * Packages: ``Neos`` `BUGFIX: Undefined array key "ui" in nodeType creationDialog `_ ------------------------------------------------------------------------------------------------------------------------------ Currently, its not possible to use the shorthand ```yaml creationDialog: elements: hasFoo: type: boolean # ui: {} # this must be set to an empty array ``` as there is an unsafe access on the ui property > Warning: Undefined array key "ui" in /Data/Temporary/Development/Cache/Code/Flow_Object_Classes/Neos_Neos_NodeTypePostprocessor_DefaultPropertyEditorPostprocessor.php line 110 regression from `#3473 `_ **Upgrade instructions** * Packages: ``Neos`` `BUGFIX: flow command typo in exception in nearestContentCollection method `_ -------------------------------------------------------------------------------------------------------------------------------------------- **Upgrade instructions** _None_ **Review instructions** Command in exception should be start with ``./flow command...`` and not ``flow command...`` !`SCR-20230605-jytx `_ * Packages: ``Neos`` `BUGFIX: CreationDialog hideable elements `_ ----------------------------------------------------------------------------------------------------------- closes cross repo issue: https://github.com/neos/neos-ui/issues/3483 In the UI it will be once https://github.com/neos/neos-ui/pull/3507 is merged possible to use the ``hidden`` property in the node creation dialog ```yaml ui: creationDialog: elements: hiddenProperty: type: string ui: hidden: true ``` This change adjusts neos creationDialogPostprocessor so that creationDialog items that are generated from properties via ``showInCreationDialog`` will have the hidden property copied ```yaml properties: hiddenProperty: type: string ui: showInCreationDialog: true inspector: hidden: true ``` **Upgrade instructions** * Packages: ``ContentRepository`` ``Fusion.Afx`` ``Neos`` `BUGFIX: Use correct configuration path for enableObjectTreeCache `_ ----------------------------------------------------------------------------------------------------------------------------------- Due to the wrong path the value of enableObjectTreeCache was always interpreted as ``false``. So in Neos in production context the Cache was disabled. * Packages: ``Neos`` `BUGFIX: RenderAttributesTrait allows Stringable objects `_ -------------------------------------------------------------------------------------------------------------------------- RenderAttributesTrait converts Stringable objects to strings via ``__toString()`` related: `#4225 `_ **Upgrade instructions** Not sure what to write here :thinking: **Review instructions** Up until 8.3 it was possible to use EelHelpers with a fluent interface like API for attributes. E.g. the following was working fine in fusion afx: ``` class={[block.element('subline').modifier('light')]} ``` The variable ``block`` is an EelHelper which returns ``self``. In 8.3 this fails with an Exception ``` $attributes may contain values of type array type: array... ``` The reason is, that with PR #4225, in ``RenderAttributesTrait`` there are two different ways the object is processed: 1. In case ``$attributeValue`` is not an array, e.g. an object, it is basically converted to a string 2. In case of an array it is checked if ``$attributeValuePart`` is actually of type plain string, boolean or null. In case of an object an exception is raised. This exception then breaks the previous behaviour in case of a ``\\Stringable`` object. * Packages: ``Neos`` ``Fusion`` `BUGFIX: point to 8.3.x-dev branch in README `_ -------------------------------------------------------------------------------------------------------------- Set the correct branch name to setup the neos-development-collection for ``8.3.x-dev`` * Packages: ``Neos`` `BUGFIX: Add translation keys in translation files `_ -------------------------------------------------------------------------------------------------------------------- The following translation keys are missing their translation in the Main.xlf file. https://github.com/neos/neos-ui/blob/7.3/packages/neos-ui/src/Containers/LeftSideBar/index.js#L82 https://github.com/neos/neos-ui/blob/7.3/packages/neos-ui/src/Containers/LeftSideBar/NodeTreeToolBar/Buttons/ToggleContentTree/index.js#L39 * Packages: ``Neos`` `BUGFIX: HtmlAugmenter & Attributes Rendering `_ --------------------------------------------------------------------------------------------------------------- Regression: https://github.com/neos/neos-development-collection/pull/4081 * Fixes: `#4213 `_ - null should not remove existing attribute Fixes applying string on existing empty attribute (or empty string) Thanks to @tellenrieder @ClaraRuna and @KommunikativCh and @fcool ;) **Upgrade instructions** * Packages: ``Neos`` ``Fusion`` `BUGFIX: Fix missing icon in case of fusion errors `_ -------------------------------------------------------------------------------------------------------------------- Change html class for icon which gets rendered if a fusion error occurs. Closes `#4223 `_ * Packages: ``Neos`` ``Fusion`` `BUGFIX: make pagination work with Traversable `_ ---------------------------------------------------------------------------------------------------------------- Fixes a warning: ``array_slice() expects parameter 1 to be array, object given in /…/Neos_ContentRepository_ViewHelpers_Widget_Controller_PaginateController.php line 124`` Variant of `#3891 `_ based on the (correct) 7.3 branch. * See: `#1112 `_ * Packages: ``Neos`` ``ContentRepository`` `BUGFIX: Add php version declaration to neos/fusion-afx `_ ------------------------------------------------------------------------------------------------------------------------- * Packages: ``Neos`` ``Fusion.Afx`` `TASK: Add missing fusion migrations and runtime helper for 9.0 `_ --------------------------------------------------------------------------------------------------------------------------------- Followup to https://github.com/neos/neos-development-collection/pull/5638 I did a full re-review on all the Fusion migrations that were copied from ``neos/rector`` The Fusion migrations were refined to ensure we handle even more cases (and in 9.0 write comments for all the things) Doing that i noticed we were missing the 8.4 api for ``node.workspaceName`` and ``node.classification.tethered`` and ``q(node).property("hiddenInMenu")`` and ~enableAfterDateTime, disableAfterDateTime~ so i added the missing runtime layers for those too. **Upgrade instructions** * Packages: ``Neos`` `TASK: Adjust README to 8.4 branch `_ ---------------------------------------------------------------------------------------------------- `TASK: Adjust to new behat refactoring from 90 and fix CI test for previous PRs `_ -------------------------------------------------------------------------------------------------------------------------------------------------- these behat refactorings were backmerged to 8.4 and thus neos needs an adjustment herby. The @Isolated tests are still broken because of changes in flow and are currently skipped in CI in favour of having some tests running already. In Neos 9 everything will be better because all the code i attemted to fix is already dead and new written. Dont you worry. `TASK: New build of neos/neos css assets `_ ---------------------------------------------------------------------------------------------------------- * Relates: `#5588 `_ * Packages: ``Neos`` `TASK: Update enshrined/svg-sanitize to ^0.22.0 `_ ----------------------------------------------------------------------------------------------------------------- Upgraded the enshrined/svg-sanitize dependency from ^0.17.0 to ^0.22.0 in composer.json due to CVE-2025-55166 Relates to: #4812 * Packages: ``Media.Browser`` `TASK: Allow neos/fusion-form in version 3.x to support neos/symfonymailer. `_ --------------------------------------------------------------------------------------------------------------------------------------------- * Packages: ``Neos`` `TASK: Update github actions to checkout@v4 and cache@v4 `_ -------------------------------------------------------------------------------------------------------------------------- * Packages: ``Neos`` ``.github`` `TASK: Check if index need to be renamed `_ ---------------------------------------------------------------------------------------------------------- In some instances the index is already renamed. This PR adds a check if this is the case and skips the migration in these cases. resolves `#5445 `_ * Packages: ``Neos`` ``ContentRepository`` `TASK: Render command references `_ --------------------------------------------------------------------------------------------------- also for Neos.ContentRepository.Migration, Neos.Neos.Setup and Neos.Setup They were simply missing in the list of command identifier which are allowed to render the command reference. See: https://github.com/neos/neos-development-collection/pull/4177#issuecomment-2598509517 * Packages: ``Neos`` `TASK: Fix MySQL migration differences on fresh setup `_ ----------------------------------------------------------------------------------------------------------------------- This eliminates some differences in the actual vs the expected DB setup in a fresh Neos 8.3 installation. * Fixes: `#3118 `_ (at least partly.) **Review instructions** ``doctrine:migrationgenerate`` should just say ``No changes detected`` after Neos has been set up. * Packages: ``Neos`` ``ContentRepository`` ``Media`` `TASK: Allow setting itemsPerPage in user administration listing `_ ---------------------------------------------------------------------------------------------------------------------------------- With Neos 8.3, pagination was added to the user management module, but the number of users page page was not made configurable and set at a very low number of 10. This non-breaking change introduces this as a setting, keeping the default of 10. * Packages: ``ContentRepository`` ``Neos`` `TASK: Make nullable parameter explicit to become PHP 8.4 compatible `_ -------------------------------------------------------------------------------------------------------------------------------------- I've used rector to migrate all occurrences. https://getrector.com/rule-detail/explicit-nullable-param-type-rector See also for Flow: https://github.com/neos/flow-development-collection/pull/3429 Note: We should run the rector migration again on 9.0 after upmerging this PR * Packages: ``.github`` `TASK: Update GitHub actions (8.3) `_ ---------------------------------------------------------------------------------------------------- Fix warnings: > The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/ * Packages: ``Neos`` ``.github`` `TASK: Update textarea docs to latest version `_ --------------------------------------------------------------------------------------------------------------- Depends on https://github.com/neos/neos-ui/pull/3821 * Packages: ``.github`` ``Neos`` `TASK: Upgrade to FontAwesome 6.5.2 `_ ----------------------------------------------------------------------------------------------------- Issue: https://github.com/neos/neos-development-collection/issues/5107 Upgraded FontAwesome in neos-development-collection to 6.5.2. Briefly tested locally and it was functioning fine. Oriented on the last upgrade branch for 5.8.2. * Packages: ``Neos`` `TASK: set new-password in EditAccount page `_ ------------------------------------------------------------------------------------------------------------- Solves https://github.com/neos/neos-development-collection/issues/4944 **Upgrade instructions** Not needed **Review instructions** Allow your password manager to autofill everything on page load. The password field (for setting new password) will not be autofilled. * Packages: ``Neos`` `TASK: Update plupload library to latest 2.3.9 `_ ---------------------------------------------------------------------------------------------------------------- Backport of https://github.com/neos/neos-development-collection/pull/5003 for 7.3 Fixes https://github.com/advisories/GHSA-rp2c-jrgp-cvr8: https://nvd.nist.gov/vuln/detail/CVE-2021-23562 * Packages: ``Neos`` ``Media.Browser`` `TASK: Update plupload library to latest 2.3.9 `_ ---------------------------------------------------------------------------------------------------------------- Fixes CVE-2021-23562: https://nvd.nist.gov/vuln/detail/CVE-2021-23562 * Packages: ``Neos`` ``Media.Browser`` `TASK: Cleanup SVG Sanitzer workaround after 0.17.0 release `_ ----------------------------------------------------------------------------------------------------------------------------- SVG Sanitizer has merged and released the fix for restoring libxml error handler. So we can remove the workaround. See: https://github.com/darylldoyle/svg-sanitizer/pull/90 * Packages: ``Neos`` ``Media.Browser`` `TASK: Fix fusion docs a little `_ ------------------------------------------------------------------------------------------------- Fixes: https://github.com/neos/neos-development-collection/pull/3915#issuecomment-1296302491 **Upgrade instructions** * Packages: ``Neos`` `TASK: PhpStan level 1 for Neos 8.3 `_ ----------------------------------------------------------------------------------------------------- Adds phpstan to the Neos 8.3 branch to all packages with a minimal level 1: - Neos.ContentRepository/Classes - Neos.Diff/Classes - Neos.Fusion.Afx/Classes - Neos.Fusion/Classes - Neos.Media.Browser/Classes - Neos.Media/Classes - Neos.Neos/Classes - Neos.NodeTypes.Form/Classes - Neos.SiteKickstarter/Classes Errors caused by the back-port of the ESCR TraversableNodeInterface, have been directly ignored via ``ignoreErrors``. Other actually fixable errors have been fixed in a non breaking way. (Adjusting the doc types e.g.) This should provide a little starting base for extending php stan level across all packages to higher levels in the upcoming 9.0 branch, where we actually use phpstan at level 8 for the following packages: - Neos.ContentGraph.DoctrineDbalAdapter/src - Neos.ContentGraph.PostgreSQLAdapter/src - Neos.ContentRepository.BehavioralTests/Classes - Neos.ContentRepository.Core/Classes - Neos.ContentRepository.Export/src - Neos.ContentRepository.LegacyNodeMigration/Classes - Neos.ContentRepository.NodeAccess/Classes - Neos.ContentRepository.StructureAdjustment/src - Neos.ContentRepository.TestSuite/Classes - Neos.ContentRepositoryRegistry/Classes - Neos.Neos/Classes (also exists in 8.3) - Neos.NodeTypes.Form/Classes (also exists in 8.3) As ``Neos.Fusion`` didnt need to be adjusted for neos 9 i started to migrate this package to level 8 for neos 8.3 already to avoid too many upmerge conflicts: https://github.com/neos/neos-development-collection/pull/4844 More packages, if applicable, will follow. **Upgrade instructions** * Packages: ``Neos`` ``ContentRepository`` ``Diff`` ``Fusion`` ``Media.Browser`` ``Media`` `TASK: Migrate Neos.Fusion/Core to phpstan level 8 (Neos 8.3) `_ ------------------------------------------------------------------------------------------------------------------------------- Requires: https://github.com/neos/neos-development-collection/pull/4842 Only files in ``Neos.Fusion/Classes/Core`` have been migrated, as they contain relatively new code like the parser. Two kind of errors have been partially ignored from the level 8 For one: "no value type specified in iterable type array" as adding ``array`` would just bloat this commit up. In these files we are mostly dealing with the fusion configuration which is highly dynamic: - Neos.Fusion/Classes/Core/Runtime.php - Neos.Fusion/Classes/Core/Cache/RuntimeContentCache.php - Neos.Fusion/Classes/Core/Cache/ContentCache.php - Neos.Fusion/Classes/Core/Cache/CacheSegmentParser.php - Neos.Fusion/Classes/Core/RuntimeConfiguration.php - Neos.Fusion/Classes/Core/ObjectTreeParser/MergedArrayTreeVisitor.php - Neos.Fusion/Classes/Core/ObjectTreeParser/MergedArrayTree.php And "has no return type specified" was noticed a lot in the ast visiting code. But i plan to refactor this instead to something better type- and readable in general: - Neos.Fusion/Classes/Core/ObjectTreeParser/MergedArrayTreeVisitor.php - Neos.Fusion/Classes/Core/ObjectTreeParser/AstNodeVisitorInterface.php - Neos.Fusion/Classes/Core/ObjectTreeParser/Ast/* **The phpstan config i used for local development & testing:**

local phpstan config

``` parameters: level: 8 ignoreErrors: - message: '#no value type specified in iterable type array.$#' paths: - Neos.Fusion/Classes/Core/Runtime.php - Neos.Fusion/Classes/Core/Cache/RuntimeContentCache.php - Neos.Fusion/Classes/Core/Cache/ContentCache.php - Neos.Fusion/Classes/Core/Cache/CacheSegmentParser.php - Neos.Fusion/Classes/Core/RuntimeConfiguration.php - Neos.Fusion/Classes/Core/ObjectTreeParser/MergedArrayTreeVisitor.php - Neos.Fusion/Classes/Core/ObjectTreeParser/MergedArrayTree.php - message: '#has no return type specified.$#' paths: - Neos.Fusion/Classes/Core/ObjectTreeParser/MergedArrayTreeVisitor.php - Neos.Fusion/Classes/Core/ObjectTreeParser/AstNodeVisitorInterface.php - Neos.Fusion/Classes/Core/ObjectTreeParser/Ast paths: - Neos.Fusion/Classes/Core bootstrapFiles: - ../Framework/bootstrap-phpstan.php ```

As phpstan `doesnt ``_ allow to configure multiple levels by path, and i dont want to have to burden running phpstan multiple times, i decided against actually linting the migrated ``Neos.Fusion/Core` code in ci for Neos 8.3. On the neos 9 branch this we will activate the full linting power though! * Packages: ``Neos`` ``Fusion`` `TASK: Correct `DoctrineProxy` import in AssetController `_ -------------------------------------------------------------------------------------------------------------------------- The old import was deprecated with ``doctrine/persistence:1.3`` and one should use Doctrine\\Persistence\\Proxy instead: https://github.com/greg0ire/persistence/blob/`da3b167cde5c029d7941941c635879524d6e1484 `_/lib/Doctrine/Common/Persistence/Proxy.php#L26 slack -> https://neos-project.slack.com/archives/C04PYL8H3/p1705607919309889 * Packages: ``Neos`` ``Media.Browser`` `TASK: Removes neos/neos-setup `_ ------------------------------------------------------------------------------------------------ **Summary:** When attempting to install Neos version 8.3 using the command ``composer create-project neos/neos-development-distribution neos-development 8.3.x-dev --keep-vcs``, the installation results in the neos-setup (version 1.x) being installed. The ``neos/cli-setup`` tool has been removed and the default command ``./flow welcome`` is still called. But the command is no longer available due to the absence of the CLI setup tool. Consequently, the setup process is not possible as the recommended command is missing. We remove the dependency from the development collection and adds the ``neos/neos-setup`` in the latest version to the `neos-development-distribution `_ * Packages: ``Neos`` `TASK: Use role label in list users/new user view if available `_ -------------------------------------------------------------------------------------------------------------------------------- In Neos 7 (and with https://github.com/neos/flow-development-collection/issues/2162), role labels were introduced. While we now have a nice table view in the "edit account" view, the role label is not displayed anywhere else. I'm aware that Neos 7 and 8 are in maintenance-only mode, but I think we all agree that Neos 8 will be around for quite a while. I suggest the minimal change to use the role label in the user list and the "new user" view if there is one. - [N/A] Code follows the PSR-2 coding style - [N/A] Tests have been created, run and adjusted as needed - [x] The PR is created against the `lowest maintained branch `_ - [x] Reviewer - PR Title is brief but complete and starts with ``FEATURE|TASK|BUGFIX`` - [x] Reviewer - The first section explains the change briefly for change-logs - [N/A] Reviewer - Breaking Changes are marked with ``!!!`` and have upgrade-instructions * Packages: ``Neos`` `TASK: Add PHP 8.3 to build workflow matrix `_ ------------------------------------------------------------------------------------------------------------- This will test Flow against PHP 8.3 * Packages: ``Neos`` ``.github`` `TASK: Fusion Behat Test Make Sure To Throw Runtime Exceptions `_ -------------------------------------------------------------------------------------------------------------------------------- Additional fix for https://github.com/neos/neos-development-collection/pull/4686 Instead of manually declaring ``@exceptionHandler`` we set it automatically for the entry point ;) This will help us detect exceptions which would otherwise be absorbed. Dont worry, this is only temporary and not at all needed with neos 9 **Upgrade instructions** * Packages: ``Neos`` `TASK: Adjust neos/neos css build to work on apple silicon `_ ---------------------------------------------------------------------------------------------------------------------------- * Packages: ``Neos`` `TASK: Add tests for FlowQuery `nextUntil`, `prevUntil`, `siblings` and `find` `_ ------------------------------------------------------------------------------------------------------------------------------------------------ The tests of ``nextUntil``, ``prevUntil``, ``siblings`` and ``find`` that were still missing. **Upgrade instructions** * Packages: ``Neos`` `TASK: Add behat tests for flowQuery cr operations `_ -------------------------------------------------------------------------------------------------------------------- This should help to ensure that the behvior of flowQuery stays compatible with Neos 9. * Packages: ``Neos`` `TASK: Add support information to package composer.json `_ ------------------------------------------------------------------------------------------------------------------------- The git url will be useful for automating the split configuration later. * Packages: ``Neos`` ``Media`` `TASK: 2nd fixup for PR #4641 ContentCollection.feature `_ ------------------------------------------------------------------------------------------------------------------------- see `#4641 `_ **Upgrade instructions** * Packages: ``Neos`` `TASK: Tweak dependency on neos/twitter-bootstrap `_ ------------------------------------------------------------------------------------------------------------------- - move the dependency from ``neos/neos`` to ``neos/media-browser`` - change from ``*`` to ``^3.0.6`` (the first version allowing Neos 7.x) * Packages: ``Neos`` ``Media.Browser`` `TASK: All dependencies within collection point to `self.version` `_ ----------------------------------------------------------------------------------------------------------------------------------- Re-adjusts dependencies to point to ``self.version`` for easier maintenance. * Fixes: `#4257 `_ * Packages: ``Neos`` `TASK: Behat-based Fusion tests (v1) `_ ------------------------------------------------------------------------------------------------------ * Related: `#3594 `_ * Packages: ``Neos`` `TASK: Fix documentation builds `_ ------------------------------------------------------------------------------------------------- … by pinning updated dependencies. **Review instructions** Best is to see if the builds succeed on RTD again with this merged… * Packages: ``Neos`` ``Media`` `TASK: Fix paths for Neos.Media RTD rendering setup `_ --------------------------------------------------------------------------------------------------------------------- The paths need to be from the repo root, not relative to the ``.readthedocs.yaml`` file (it seems). * Packages: ``Neos`` ``Media`` `TASK: Add configuration files for RTD `_ -------------------------------------------------------------------------------------------------------- This add ``.readthedocs.yaml`` files for the collection (handling ``Neos.Neos``) and for ``neos.Media``, to solve failing documentation rendering. **Review instructions** This can be compared to the configuration we have in place for ``Neos.Flow`` in the Flow development collection. * Packages: ``Media`` `TASK: Avoid potential deprecation warnings `_ ------------------------------------------------------------------------------------------------------------- ``trim()`` and ``preg_match()`` expect strings, but Eel with it's loose typing might pass in different types. * Packages: ``Neos`` ``Fusion`` `TASK: add default value for generatorName at kickstart command in SiteKickstarter `_ ---------------------------------------------------------------------------------------------------------------------------------------------------- We tried to reproduce #4053. We can't reproduce this issue, but while reproducing we found a flow command prompt, without a default value. The command ``flow kickstart:site AnySite.Site`` asks for a site generator. We added a default value by adding: ```php array_key_first($selection) ``` **Review instructions** At https://github.com/neos/neos-development-collection/blob/`79dd4e1a26b7ffceb80cc628fdbe570ff6013b16 ``_/Neos.CliSetup/Classes/Command/SetupCommandController.php#L165 ``array_key_last`` is used. Should we use ``array_key_last`` too or is ``array_key_first` fine for it? * Packages: ``SiteKickstarter`` `TASK: PHP 8.1 deprecations compatibility `_ ----------------------------------------------------------------------------------------------------------- This tweaks the code so that it runs without deprecations on PHP 8.1. **Upgrade instructions** None. **Review instructions** None. * Packages: ``Fusion`` ``Neos`` `TASK: Change variablename in Neos Fusion documentation `_ ------------------------------------------------------------------------------------------------------------------------- Now use "myString" in documentation, because the return value is a string and not an array. This can lead to confusion under certain circumstances. **Upgrade instructions** * Packages: ``Neos`` `TASK: Adjust link editor documentation `_ --------------------------------------------------------------------------------------------------------- Tiny mistake in link editor documentation: To refer to another node type the reference **property** type is used, not the reference node type. * Packages: ``Neos`` `TASK: Require all collection packages as self.version `_ ------------------------------------------------------------------------------------------------------------------------ Any dependency from one package in the collection to another should always be "to the same version". This changes makes sure this is the case by using ``self.version`` as the required version. See `#4257 `_ **Upgrade instructions** * Packages: ``Neos`` ``Fusion.Afx`` ``NodeTypes.AssetList`` ``NodeTypes.BaseMixins`` ``NodeTypes.ColumnLayouts`` ``NodeTypes.ContentReferences`` ``NodeTypes.Form`` ``NodeTypes.Html`` ``NodeTypes.Navigation`` `TASK: Apply fixes from StyleCI `_ ------------------------------------------------------------------------------------------------- This pull request applies code style fixes from an analysis carried out by `StyleCI `_. --- For more information, click `here `_. * Packages: ``Neos`` ``ContentRepository`` ``Fusion.Afx`` ``Fusion`` ``Media`` ``SiteKickstarter`` `DOCS: Fix indentation of ImageEditor options `_ --------------------------------------------------------------------------------------------------------------- * Packages: ``Neos`` `Detailed log `_ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~