Overview of merged pull requests¶
Comparing objects in Fluid templates using == may lead to “nesting level too deep” errors, depending on the objects being compared.
This change adjusts all non-strict comparisons against strict ones.
This change fix a JS console error, when ember try to call _applyChangeHandler on property like _nodeType, because this property is not really an editor.
This moves added labels to the Neos.Media.Browser package and adjusts the RelatedNodes.html template as needed.
Some german translations are moved as well.
This change contains a fix and additional Behat tests which solves an issue with moving and publishing nodes in a nested workspace scenario which can lead to data corruption in the content repository.
This changes the occurrences of Neos.Neos:Main:upload to Neos.Neos:Main:choose in Settings.yaml, as this has been the label formerly used for upload-related Inspector editors.
The label Neos.Neos:Main:upload does not seem to exist currently, so the tooltips above upload buttons in the Inspector haven’t been translated.
<!– Thanks for your contribution, we appreciate it!
Please read through our pull request guidelines, there are some interesting things there: https://discuss.neos.io/t/creating-a-pull-request/506
And one more thing… Don’t forget about the tests! –>
What I did Fix the missing translation for the upload buttons in the image and asset inspector editors.
How I did it Change all occurrences of Neos.Neos:Main:upload to Neos.Neos:Main:choose in Settings.yaml.
How to verify it
Hover above the upload Button of the image editor. Without this change, the tooltip contains the fallback label “Upload file” in every language.
- [x] Code follows the PSR-2 coding style
- [x] Tests have been created, run and adjusted as needed
- [x] The PR is created against the [lowest maintained branch](https://www.neos.io/features/release-roadmap.html) PR is against 3.0, since the problem doesn’t seem to occur prior to that
Even if the property is set to null AbstractNodeData::hasProperty() should return true.
To detect links to assets as “usage” in the media management, the search in the NodeDataRepository is amended as needed.
Fixed some misleading text on the listing page and added i18n.
related to #1578.
for 3.x upmerge have a look at https://github.com/ComiR/neos-development-collection/commit/e2d0e44dd6f21179b2e9eeeac1481ae3a4f8a3f6.
This change fixes asset rendering in the workspace overview.
This changes an issue with using the PublishingService::publishNode() which can result in an inconsistent structure in a user’s workspace.
This change also changes the behavior of PublishingService::discardNode() which now will also discard content of a given document node to protect consistency.
Document nodes and their content must be published or discarded together in order to protect against inconsistencies when the document node is moved or removed in one of the base workspaces.